HTML5 UI doesn't handle jitter of >1 sec well

evristzam / ndt

Automatically exported from code.google.com/p/ndt

Other

0 stars 0 forks source link

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

If the jitter is >1 sec, it swaps to scientific notation. It should just swap 
the units. See attached PNG for an example.

Original issue reported on code.google.com by AaronMat...@gmail.com on 10 Mar 2015 at 12:47

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by AaronMat...@gmail.com on 10 Mar 2015 at 1:25

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 11 Mar 2015 at 12:28

GoogleCodeExporter commented 9 years ago

Fix available on Issue169 branch

Original comment by skost...@soldevelo.com on 11 Mar 2015 at 1:20

GoogleCodeExporter commented 9 years ago

Are these changes ok to merge into trunk?

Original comment by skost...@soldevelo.com on 18 Mar 2015 at 5:13

GoogleCodeExporter commented 9 years ago

The code looks reasonable. Have you tested in both the jitter >1sec and jitter 
<1sec cases?

Original comment by AaronMat...@gmail.com on 19 Mar 2015 at 5:12

GoogleCodeExporter commented 9 years ago

Yes, when jitter value is >1sec then its unit js properly changed from ms to 
seconds.

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 8:31

GoogleCodeExporter commented 9 years ago

If both cases have been tested, commit at will

Original comment by AaronMat...@gmail.com on 20 Mar 2015 at 11:48

GoogleCodeExporter commented 9 years ago

Merged into trunk

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 12:12