Speeds >100Mbps aren't displayed properly

evristzam / ndt

Automatically exported from code.google.com/p/ndt

Other

0 stars 0 forks source link

Speeds >100Mbps aren't displayed properly #173

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

I don't have a good screenshot and can't generate one right now, but if you do 
a test with >100Mbps speeds, the results page has the speeds in scientific 
notation. It should, similar to the jitter, swap the units to Gbps with a max 
of 2 decimal points.

Original issue reported on code.google.com by AaronMat...@gmail.com on 10 Mar 2015 at 1:23

Blocking: #162

GoogleCodeExporter commented 9 years ago

Original comment by AaronMat...@gmail.com on 10 Mar 2015 at 1:25

Now blocking: #162

GoogleCodeExporter commented 9 years ago

Example problem with ~130Mbps

Original comment by AaronMat...@gmail.com on 10 Mar 2015 at 3:30

Attachments:

[Screen Shot 2015-03-10 at 11.28.27 AM.png](https://storage.googleapis.com/google-code-attachments/ndt/issue-173/comment-2/Screen Shot 2015-03-10 at 11.28.27 AM.png)

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 11 Mar 2015 at 1:22

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Fix available on Issue173 branch

Original comment by skost...@soldevelo.com on 11 Mar 2015 at 2:05

Changed state: Complete

GoogleCodeExporter commented 9 years ago

The mb/s is getting pushed onto the lower level now.

Original comment by AaronMat...@gmail.com on 13 Mar 2015 at 1:50

Changed state: Started

Attachments:

[Screen Shot 2015-03-13 at 9.49.01 AM.png](https://storage.googleapis.com/google-code-attachments/ndt/issue-173/comment-5/Screen Shot 2015-03-13 at 9.49.01 AM.png)

GoogleCodeExporter commented 9 years ago

I've slightly changed font size of this numbers to be smaller. Now should be ok

Original comment by skost...@soldevelo.com on 13 Mar 2015 at 2:23

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

The font sizes look fine now. Have you tested it at >100M speeds? My current 
test host is limited to 100M.

Original comment by AaronMat...@gmail.com on 13 Mar 2015 at 2:41

GoogleCodeExporter commented 9 years ago

It turned out for me that sometimes it showed properly and sometimes not 
(probably depended on exact values). I have changed font size again so that now 
all real values should be visible in one line.

Original comment by skost...@soldevelo.com on 13 Mar 2015 at 3:04

GoogleCodeExporter commented 9 years ago

Are these changes ok to merge into trunk?

Original comment by skost...@soldevelo.com on 18 Mar 2015 at 5:13

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 19 Mar 2015 at 12:30

Changed state: Complete

GoogleCodeExporter commented 9 years ago

The code looks reasonable. Have you tested in both the >100Mbps and <100Mbps 
cases/

Original comment by AaronMat...@gmail.com on 19 Mar 2015 at 5:13

GoogleCodeExporter commented 9 years ago

Both on values >100Mbps and <100Mbps speed values and their units where 
displayed for me properly in one line as expected.

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 8:33

GoogleCodeExporter commented 9 years ago

Also units are properly changed to gb/s when values get higher :)

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 8:37

GoogleCodeExporter commented 9 years ago

Commit at will then

Original comment by AaronMat...@gmail.com on 20 Mar 2015 at 11:49

GoogleCodeExporter commented 9 years ago

Merged into trunk

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 12:14

Changed state: Fixed