Correct NDT compressed log file extension

evristzam / ndt

Automatically exported from code.google.com/p/ndt

Other

0 stars 0 forks source link

Correct NDT compressed log file extension #36

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Currently NDT is using zlib to handle compression, specifically
trunk/src/logging.c makes calls to the zlib deflate() function to compress
the log files.  This example code from an on-line tutorial, but this does
not make them 'gzip' files.

The http://www.zlib.net/zlib_how.html page contains the example used to
write the deflate routine.  Pulling the zpipe.c file off of this web page,
and compiling it will be enough to uncompress the snaplog and tcpdump log
files.  

The 'fix' in this case should be to note this, and change the extension to
note that these are not zip files.

Original issue reported on code.google.com by jwzuraw...@gmail.com on 9 Mar 2010 at 3:30

GoogleCodeExporter commented 9 years ago

Hi Rich,

what is the status of this ticket?

Original comment by jslawin...@soldevelo.com on 10 Mar 2014 at 1:23

GoogleCodeExporter commented 9 years ago

Would it make more sense to actually gzip the file instead of using the deflate 
algorithm? That'd be more user-friendly i'd think, at the risk of breaking 
something that (e.g.) mlab might be using.

Original comment by AaronMat...@gmail.com on 10 Mar 2014 at 1:27

GoogleCodeExporter commented 9 years ago

Original comment by jwzuraw...@gmail.com on 10 Mar 2014 at 1:32

GoogleCodeExporter commented 9 years ago

I agree with Aaron - we should gzip the files.

Original comment by jslawin...@soldevelo.com on 15 Apr 2014 at 6:58

GoogleCodeExporter commented 9 years ago

Original comment by jslawin...@soldevelo.com on 25 Jun 2014 at 8:07

Added labels: Milestone-NDT-Future

GoogleCodeExporter commented 9 years ago

Original comment by jslawin...@soldevelo.com on 25 Jun 2014 at 8:08

Added labels: Milestone-Future
Removed labels: Milestone-NDT-Future

GoogleCodeExporter commented 9 years ago

Original comment by jslawin...@soldevelo.com on 12 Feb 2015 at 8:39

Added labels: Milestone-NDT-3.7.0
Removed labels: Milestone-Future

GoogleCodeExporter commented 9 years ago

Original comment by skost...@soldevelo.com on 16 Feb 2015 at 1:18

GoogleCodeExporter commented 9 years ago

Changes available on Issue36 branch. Please feel free to review.

Original comment by skost...@soldevelo.com on 16 Feb 2015 at 1:19

Changed state: Complete

GoogleCodeExporter commented 9 years ago

Aaron, could you please verify that these changes are ok and solved issue ? I 
think this and Issue165 are good to have been fixed before releasing NDT 3.7.0 
so if they look ok then we could merge them into trunk.

Original comment by skost...@soldevelo.com on 18 Feb 2015 at 9:17

GoogleCodeExporter commented 9 years ago

This seems reasonable

Original comment by AaronMat...@gmail.com on 18 Feb 2015 at 3:26

GoogleCodeExporter commented 9 years ago

Thank you for review. I've merged these changes into trunk

Original comment by skost...@soldevelo.com on 18 Feb 2015 at 4:24

Changed state: Fixed