evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

Fix for middlebox NAT detection #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Currently ndt will compare hostname/dns resolved names rather than IP addresses 
directly when checking for NAT.
Often the server will detect a different host name for the client than what the 
client detects for itself. And visa versa. Hence falsely detects a NAT.

Putting a manual entry into /etc/hosts and is all most guaranteed to cause this.

What is the expected output? What do you see instead?
NDT should check for NAT based on IP addresses not host names. 

Expected behaviour
~~
wand@quarterpounder:~$ ./web100clt -n 10.1.18.175
...
Server IP addresses are preserved End-to-End
Client IP addresses are preserved End-to-End
~~

Current behaviour
~~
wand@quarterpounder:~/ndt-3.6.4/src$ ./web100clt -n 10.1.18.175
...
Information: Network Address Translation (NAT) box is modifying the Server's IP 
address
    Server says [10.1.18.175] but Client says [ dhcp-175.uni.crc.net.nz]
Information: Network Address Translation (NAT) box is modifying the Client's IP 
address
    Server says [10.1.18.217] but Client says [ dhcp-217.uni.crc.net.nz]
~~

What version of the product are you using? On what operating system?
r936 - Present since at least 3.6.4.

Please provide any additional information below.
Attached patch.

The current I2AddrNodeName way of doing this ultimately retrieves its values 
from getnameinfo.

I haven't looked at the java client, it might also require a similar fix.

Original issue reported on code.google.com by rsanger...@gmail.com on 10 Jan 2013 at 4:01

Attachments:

GoogleCodeExporter commented 9 years ago
Correction present in current svn r796.

Original comment by rsanger...@gmail.com on 10 Jan 2013 at 4:03

GoogleCodeExporter commented 9 years ago
Patch applied

Original comment by AaronMat...@gmail.com on 9 Apr 2013 at 1:57