evristzam / ndt

Automatically exported from code.google.com/p/ndt
Other
0 stars 0 forks source link

Various Java applet bugs - request review #74

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Various Java applet bugs below

* Added try catch around parseInt so large numbers wont cause the analysis to 
stop.

* Fix "/" removal for client ip, for whatever reason IP's end up with a "/" and 
need to be removed. A typo sClientSideServerIp instead of ClientSideClientIp 
tries to remove the "/" from the wrong string. This causes it to always detect 
a client side NAT.

* If TCP timestamps enabled add 12 to the MSS, like the c client does.

* Typo in localization 'clientIpPreserved = Server IP addresses are preserved 
End-to-End' should be 'clientIpPreserved = Client IP addresses are preserved 
End-to-End'. 
NOTE: This appears to be incorrect in the other languages also, someone who 
knows the language should also fix these.

Find patch attached

Original issue reported on code.google.com by rsanger...@gmail.com on 23 Jan 2013 at 4:43

Attachments:

GoogleCodeExporter commented 9 years ago
They look good to me

Original comment by aa...@internet2.edu on 24 Jan 2013 at 6:58

GoogleCodeExporter commented 9 years ago
Patch applied

Original comment by AaronMat...@gmail.com on 9 Apr 2013 at 1:57

GoogleCodeExporter commented 9 years ago
Greek localization updated, here are the files. If possible, please include the 
.uproperties file as well. If one would want to correct something else in the 
future, one would find it very convenient to edit the .uproperties utf8 encoded 
file and produce the .properties file using the native2ascii command included 
in the standard jdk.

Original comment by aduit...@gmail.com on 9 Apr 2013 at 2:42

Attachments:

GoogleCodeExporter commented 9 years ago
Could you create a new issue for this instead of adding it as a comment on an 
existing one? (especially one that is closed)

Original comment by AaronMat...@gmail.com on 19 Apr 2013 at 4:55