Closed lcat closed 4 years ago
@KODerFunk hei~
Test cases have been added, no
and px
is a reference https://github.com/songsiqi/px2rem
@lcat hei!
Tests are good!
But I still worry about the correct expected result of the plugin.
First, no
and px
are too simple common words.
Secondly, we just need to be able to work without conflicts with other postcss-plugins.
Prease,
1) replace no
and px
to postcss-px-to-viewport-ignore
2) describe postcss-px-to-viewport-ignore
comment directive in example in README.md and README_CN.md
@lcat Hi guys, when are you planning to have this merged?
@likun7981 This is a good feature! I’ll try to find the time this month to complete and release the update, but I need a translation for the readme before release, I will call you there later.
@KODerFunk Hi, how is it going now?
And, how about the comments like px-to-viewport-disable
or px-to-viewport-ignore
? Shorter without postcss-
prefix.
@hsxfjames good idea with naming. I working on this feature by correct post-css api. The next release of these days.
https://github.com/evrone/postcss-px-to-viewport/commit/9d6c5cee5eea367fb4c7cf0c3bb1117979b5fbf4
/* px-to-viewport-ignore */
and /* px-to-viewport-ignore-next */
— special comments for ignore conversion of single lines.
Sometimes selectorBlackList is not easy to use.
example: