search

evrone / postcss-px-to-viewport

A plugin for PostCSS that generates viewport units (vw, vh, vmin, vmax) from pixel units. The best choice to create a scalable interface on different displays by one design size.
https://evrone.com/postcss-px-viewport
MIT License
3.04k stars 406 forks source link

fix: Prevent input undefined #33

Closed lzm0x219 closed 5 years ago

lzm0x219 commented 5 years ago

🙏

KODerFunk commented 5 years ago

Hi @ppokemon! Can you describe your problem in more detail? In what situation source is not defined?

lzm0x219 commented 5 years ago

emmm.

lzm0x219 commented 5 years ago 
"parcel-bundler": "^1.12.3",
"postcss-aspect-ratio-mini": "^1.0.1",
"postcss-font-magician": "^2.2.1",
"postcss-modules": "^1.4.1",
"postcss-preset-env": "^6.6.0", // Undefined using these plugins
lzm0x219 commented 5 years ago

I didn't figure out exactly what plugin was causing undefined, but this commit can circumvent this problem.

KODerFunk commented 5 years ago

@ppokemon postcss-preset-env have mass dependencies. Can you list error from terminal there?

lzm0x219 commented 5 years ago

@KODerFunk The dev branch can reproduce this problem

KODerFunk commented 5 years ago

@ppokemon, ok, i detect problem. It is from postcss-modules-values. It append rules with selector :export that can be ignored. Ok! Merge, but new version in npm at the end of week. Pika pika!

lzm0x219 commented 5 years ago

@KODerFunk Thanks!!!😆

lzm0x219 commented 5 years ago

new version？？？

KODerFunk commented 5 years ago

Oh sorry! My bad! Tomorrow.

KODerFunk commented 5 years ago

@ppokemon I coped with the release! v1.1.1 Thanks again!

lzm0x219 commented 5 years ago

@KODerFunk yeah! I see~ 😀