search

evroon / bracket

Selfhosted tournament system
https://docs.bracketapp.nl
GNU Affero General Public License v3.0
218 stars 49 forks source link

Discrepancies between API interface StageItemWithRounds and frontend's StageItemWithRounds #816

Open robigan opened 3 months ago

robigan commented 3 months ago

The frontend defines StageItemWithRounds as https://github.com/evroon/bracket/blob/48ba51a3e72be7868d2b327d2393c6fb4812b7cd/frontend/src/interfaces/stage_item.tsx#L4-L15 but the API defines it as

image

Note the discrepancies in fields ournament_id/stage_id and the additional field is_active. Is this correct? As I see that in https://github.com/evroon/bracket/blob/48ba51a3e72be7868d2b327d2393c6fb4812b7cd/frontend/src/pages/tournaments/%5Bid%5D/swiss/%5Bstage_item_id%5D.tsx#L80 stage_id is utilized, but TypeScript complains that this property doesn't exist on the interface defined. So I'm opening this issue to confirm you meant stage_id and not tournament_id.

robigan commented 3 months ago

this bug would be addressed in #530

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 60 days with no activity. What is the action to take here?