search

evrowe / vscode-ember-syntax

Ember HTMLBars and Glimmer syntax highlighting
2 stars 1 forks source link

Syntax/grammar does not work on Linux Mint (based on Ubuntu) #2

Open Krzyrok opened 6 years ago

Krzyrok commented 6 years ago

Hi. I've installed your extension but it doesn't work - it broke handlebars. Automatic language detection selected "Glimmer" (previously I had "Handlebars") - but I have no syntax highlight: handlebars

Inline templates also does not work: js

OS: Linux Mint 18.2 (based on Ubuntu 16.04) Node: 8.4.0 vs code: 1.16.0 Ember Syntax: 0.5.0

saosebastiao commented 6 years ago

Also experiencing this on Ubuntu 16.04 LTS

Is this just a linux issue? Hard to see how this would be related to the OS.

evrowe commented 6 years ago

Interesting, I’ve not personally seen this on macOS or Windows but I can set up a VM and take a look. Might not be an OS-specific issue so much as the way a particular package/dependency is built (or substituted) for a Linux environment. On Sat, Oct 28, 2017 at 11:36 saosebastiao notifications@github.com wrote:

Also experiencing this on Ubuntu 16.04 LTS

Is this just a linux issue? Hard to see how this would be related to the OS.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/healthsparq/vscode-ember-syntax/issues/2#issuecomment-340211172, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOWfSM6Y50tPjpBw-nSUeApxMiNwvaOks5sw3Q9gaJpZM4PSRso .

nyon commented 6 years ago

Same problem here on Ubuntu 16.04 LTS.

VSCode Version information:

Version 1.19.1 Commit 0759f77bb8d86658bc935a10a64f6182c5a1eeba Date 2017-12-19T09:41:01.414Z Shell 1.7.9 Renderer 58.0.3029.110 Node 7.9.0 Architecture x64

mvrkljan commented 6 years ago

Same issue still, on Ubuntu 16.04 LTS.

Version 1.21.1 Commit 79b44aa704ce542d8ca4a3cc44cfca566e7720f1 Date 2018-03-14T14:46:30.761Z Shell 1.7.9 Renderer 58.0.3029.110 Node 7.9.0 Architecture x64

mvrkljan commented 6 years ago

Is it known what causes this issue, on dependencies level? Should an issue be opened somewhere else?

brokenalarms commented 6 years ago

Same issue; can't use VSCode at work as a result. Anyone found any alternate solutions?

robclancy commented 6 years ago

Issue open for over 6 months. Works in windows and not linux so obvious thing to check is paths. Find the issue in 10 minutes.

https://github.com/healthsparq/vscode-ember-syntax/blob/master/package.json#L64

Needs to be a lowercase G.

This package is a bit of a mess anyway the way it is built by copying files around. Works for me now manually editing locally.

DHedgecock commented 6 years ago

Hello, I no longer maintain this package. Someone from the Ember community will need to step up and take it over.

For anyone interested in contributing, VSCode now supports grammar injection (which wasn't available 11 months ago), so this whole package could be radically cleaned up and simplified to inject the syntax rules into JS scopes instead of the whole copy/inject dance that's curretly setup.

For a great example of how this could be setup, see the styled components VSCode extension: https://github.com/styled-components/vscode-styled-components

Good luck!

robclancy commented 6 years ago

I'd like to but really don't have time. Surprised by the lack of ember vscode add-ons in general really.