evryfs / helm-charts

OpenSourced Helm charts
Apache License 2.0
49 stars 75 forks source link

github-actions-runner-operator github app integration and secret #176

Open deeco opened 2 years ago

deeco commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

Reference Kubernetes secret is not clear if supported in values file for github app here , is it mount additional volume and reference the secret or reference the secret name directly. do we just reference the app id and the existing secret created from pem key ?

envFrom:

Version of Helm and Kubernetes:

3 , 1.23

Which chart:

github-actions-runner-operator https://github.com/evryfs/helm-charts/blob/75b8ed938c643fb606b896f2d670add4a109e118/charts/github-actions-runner-operator/values.yaml#L73