search

evryfs / helm-charts

OpenSourced Helm charts
Apache License 2.0
49 stars 75 forks source link

Allowing user to configure global and per-tier labels #184

Open syalioune opened 2 years ago

syalioune commented 2 years ago

Thanks for maintaining this chart.

The purpose of this PR is to give more flexibility by allowing users to provide common and per tier (frontend/backend) labels. Existing labels have been integrated into default values file.

syalioune commented 2 years ago

Hello @davidkarlsen, I see that linters are failing since the chart version did not change. I was not sure if version bump was at the discretion of maintainers. Do you expect a commit from me to set chart version to 1.4.2 ? Thanks

davidkarlsen commented 2 years ago

Yes please so that it can pass CI

syalioune commented 2 years ago

Done :smiley:

syalioune commented 2 years ago

Hello @davidkarlsen, it's been done !

syalioune commented 1 year ago

Hello David, any issues preventing merging this branch ?

hardwarefresser commented 1 year ago

I would also like to ask kindly for a merge.