search

evryfs / helm-charts

OpenSourced Helm charts
Apache License 2.0
49 stars 76 forks source link

[ecr-proxy] need to be able to specify ingressClassName #226

Open Tstrul-work opened 1 year ago

Tstrul-work commented 1 year ago

Is your feature request related to a problem? Please describe. We are running multiple ingressclasses, so we need to be able to specify the spec.ingressClassName on the ingress. the deprecated kubernetes.io/ingress.class annotation no longer works on the latest controllers.

Describe the solution you'd like To be able to specify ingress.ingressClassName in the helm values.yaml file - this would then generate a spec.ingressClassName entry in the ingress, with the value that was specified in the values.yaml file

Describe alternatives you've considered Only manually editing the ingress

Additional context Same problem that was reported and fixed on dependency-track issue

datze commented 1 year ago

ingress: enabled: true ingressClassName: nginx