evseevnn-zz / php-cassandra-binary

PHP library for Cassandra database via a binary protocol.
http://evseevnn.github.io/php-cassandra-binary/
MIT License
69 stars 33 forks source link

Update getRandomNode() to work with credentials: #13

Closed advait closed 10 years ago

advait commented 10 years ago
evseevnn-zz commented 10 years ago

Previously, the logic was:

If one node does not fit, then try the following and to report that the connection settings a node specified is not correct.

If no node is not approached, then to report that none of the node does not have the correct parameters.

hmm ...

You suggest, while clean and not try to find the correct the connection settings to the node ....

My argument would be that look correct settings node: When adding a new node to the cluster, a typo will have less serious consequences.

However, the likelihood that someone who will add a new node makes a mistake is very small.

ok. Please bring an argument in support of his decision.

advait commented 10 years ago

I tried to preserve the logic of the previous implementation. The main reason for this pull request is to fix #14. I will address your comments in a second. Thoughts?

evseevnn-zz commented 10 years ago

fixed in b106851