search

evshiron / nwjs-builder

https://www.npmjs.com/package/nwjs-builder
76 stars 12 forks source link

Cannot build without side-by-side #19

Closed darshanshankar closed 8 years ago

darshanshankar commented 8 years ago

Win 10, Node 4.4, nwjs 0.14.5, nwjs-builder 1.6.0

Can't open my app if I use --side-by-side to build it. Getting a checksum error when using 7zip to unzip the .exe binary. Any idea why that could be?

evshiron commented 8 years ago

Thanks for the report. This is because util.CombineApplication doesn't work as expected on Windows (and results in a copy /b a.exe b.exe). I am looking into it.

evshiron commented 8 years ago

Uh-huh, it seems like an issue with rcedit.exe now.

evshiron commented 8 years ago

Fixed now. By simply editing executable before combining application. Please upgrade to nwjs-builder 1.8.1.