search

evshiron / nwjs-builder

https://www.npmjs.com/package/nwjs-builder
76 stars 12 forks source link

Fix build error from mac icns and add icons to test. #21

Closed orther closed 8 years ago

orther commented 8 years ago

The build wouldn't work when setting the macIcns due to missing this in lib/build/darwin so I fixed that.

I also added some example icon files (random free one from a google) and updated the test-module to use them.

evshiron commented 8 years ago

Thanks for the PR. That might be something forgotten when I decided to use context and bind it to the generator for workaround purpose. Would you might move the test/assets/ to nwb-test/assets/ before I merge this PR? Because at the moment src/ will be ignored by .npmignore (in fact the nwb-test/ is bad, a refactoring is needed in the future).

evshiron commented 8 years ago

Merged. Thanks :)