add mirror switch so we can build/download from a mirror, also add sw…

evshiron / nwjs-builder

https://www.npmjs.com/package/nwjs-builder

76 stars 12 forks source link

Closed stackmagic closed 8 years ago

stackmagic commented 8 years ago

…itches to the download command, add gitignore file

not sure if the bin/ and lib/ should be committed? i can remove them and make a new PR if you pefer that

evshiron commented 8 years ago

Thanks for the PR. Here are some changes required:

bin/ and lib/ should not be committed, as they are built by scripts
I prefer using URL_MIRROR rather than MIRROR_URL
.gitignore should have a leading /, otherwise for example src/lib/test/ might be omitted too
- In fact I have a local .gitignore and would you mind letting me push that?
It will be nice if there is a test for it :)

It will be appreciated if you can help with these. Thanks for your great effort.