Closed evshiron closed 8 years ago
--side-by-side
is added too in c2004af.
Propose: --production
, which doesn't copy the node_modules
, but execute npm install --production
when copying is done, which will strip devDependencies out and reduce file size.
--production
is added in 039e866.
Propose: --win-ico
and --osx-icns
.
-o, --buildDir <buildPath>
The build folder [default: "./build"]
@nicklaw5 Thanks for the suggestion, added in 820718d. README and published version are also updated.
+1 for icons
@conceptualspace --win-ico
and --mac-icns
are added long ago. Feel free to try them out and feedback is appreciated.
will do! and thanks for your work on this
Can you please update README with all the options that are available.
@mato75 I think all the options are listed in the "Usage" section. If you want a reference, please see test/test-module.js
.
Options that would be awesome to have:
argv: [], // custom arguments passed to nwjs
port: 1245 // custom port on which nwjs is running
What the port
means? Is it for --remote-debugging
? It's a good proposition though. I will consider adding it in the next days.
Yes for remote debugging. I am using nwjs for testing and connecting chrome-remote-interface to it.
And also custom arguments are really useful. I am using it with web sockets.
Maybe instead of setting every available setting as an option, set argv, and user will have to add them on its own (---remote-debugging, --allow-running-insecure-content, ...) and library only reads the argv option.
I will see how the underlying commander.js supports this.
@mato75 Custom arguments should be usable in nwjs-builder
1.10.0. There are examples in README and test/test-nwbuild.js
. Feel free to try it out.
How do you set them when used inside *.js (I dont see an extra option, that will allow me to add custom arguments)?
@mato75 This should work:
const NWB = require('nwjs-builder');
NWB.commands.nwbuild(['--remote-debugging-port=9222', './build/', '-a', 'bbb'], {
run: true
}, (err, code) => {});
Would be great if there was an option to include the version number in the build folder name.
For example, stryve-v0.3.0-win-x64
rather than just stryve-win-x64
@nicklaw5 --output-name
is added in nwjs-builder
1.10.5. The feature is powered by string-template
and in your situation --output-name "{name}-v{version}-{target}"
should do the trick.
I am closing this issue now as it's too long. If there is any proposition, feel free to open a new issue.
--with-ffmpeg
is added now. What about--side-by-side
, which doesn't combineapp.nw
to the executable?