search

evshiron / nwjs-builder

https://www.npmjs.com/package/nwjs-builder
76 stars 12 forks source link

Blank ".done" directory created during output #31

Closed charlielee closed 8 years ago

charlielee commented 8 years ago

A very small bug I've noticed is that a blank directory titled .done is created in the output directories for all platforms.

evshiron commented 8 years ago

Thanks for the report. The .done is created to indicate if a decompressing process is succeeded. And yes it should be fixed, please wait until I have some time to have it settled later in this day.

evshiron commented 8 years ago

In nwjs-builder 1.11.2, the .done directory will not be included in builds.

charlielee commented 8 years ago

This issue does not to appear to have been resolved in 1.11.15.

evshiron commented 8 years ago

@BoatsAreRockable But it's tested in test-module.js and if there is a .done, the test will fail. Feel free to reopen this issue and it is appreciated if more information is provided.