evshiron / nwjs-builder

https://www.npmjs.com/package/nwjs-builder
76 stars 12 forks source link

Using `--version` shows an nwjs-builder package version and does nothing (unlike -v). #59

Open CosmoMyzrailGorynych opened 7 years ago

CosmoMyzrailGorynych commented 7 years ago

Like so:

$ D:\_namespace\_cosmicEveryday>nwb nwbuild --production --version v0.19.5 --platforms win32,win64 --win-ico ico.ico --output-dir D:\_namespace\_cosmicEverydayBuilds\

1.14.0

And then the process exits.

Intended behaviour: download nwjs and start packaging; --version should specify an nw.js version for download, like in --help command:

default

-v flag works well, though.

evshiron commented 7 years ago

Ouch. That should be something with the commander dependency, which is used to parse command line arguments in nwjs-builder. Thanks for the issue and I will look into it soon.

evshiron commented 7 years ago

Hmm, after reading the code of commander, I think removing this line should do the trick.