why parse function only parsed 100 tlv?

[royzhao]

for(int i=0; i<100; i++) { ParseResult result = parseWithResult(0, aBuf, offset, aLen-offset); tlvs.add(result.tlv);

if(result.offset>=aOffset+aLen) {
    break;
}

offset = result.offset;

}

i think that code is better

int curOffset; do { ParseResult result = parseWithResult(0, aBuf, offset, aLen-offset); tlvs.add(result.tlv);

  if(result.offset>=aOffset+aLen) {
      break;
  }
  curOffset = result.offset;

  offset = result.offset;

} while (curOffset<aOffset+aLen);

[IonutNegru87]

Wondering about this also - is this just to avoid very long parses? That magic number of 100 does not really make sense.

[eximius313]

simple:

    int offset = aOffset;
    do {
      final ParseResult result =  parseWithResult(0, aBuf, offset, aLen-offset);

      tlvs.add(result.tlv);
      offset = result.offset;
    } while(offset < aOffset+aLen);

passes all the tests

[martinpaljak]

it's usually about not having unbound loops on possibly unverified input.

[eximius313]

fair point. But this could be left as a setting