[v4.2.2] "Relative to course module completion" can be added even if there are no completable modules

danowar2k commented 8 months ago

Just saw another problem with "relative to course module completion" availability.

I enabled course completion on a pre-existing course with pre-existing activities
I went into a course module's settings
I added "relative to course module completion" availability
The dropdown was empty because no activity had any sort of completion enabled, so no activity could be selected per default

As of now I'm unsure if and what one could do about this:

Could it be prevented to be able to add "relative to course module completion" availability condition if there are no completable course modules?
If not, could it be prevented to save the condition if there is no selectable course module?

danowar2k commented 8 months ago

It looks like this could easily be prevented by checking for at least one completable course module here: https://github.com/ewallah/moodle-availability_relativedate/blob/main/classes/frontend.php#L67

ewallah commented 8 months ago

Fixed

ewallah / moodle-availability_relativedate