ewanhills / hillsReactApp

My React Application
0 stars 0 forks source link

Feedback #1

Open diarmuidoconnor opened 4 years ago

diarmuidoconnor commented 4 years ago

I have reviewed your work and have some questions:

Please discuss these with me asap as I cannot assign a mark right now.

ewanhills commented 4 years ago

Hi Diarmuid, 1) The intention is that the customer can browse a list of items then add them, I intend to add this for the second half of the assignment ie the back end.

2) As of now items have to manually coded if they are to be added to the webpage. Again looking to addressed this for the second half.

3) I had an issue with storybook, when I added more than the default amount it failed to run so I have removed them for now thanks.

diarmuidoconnor commented 4 years ago

Having worked their way through the two lab apps, I hoped students would understood the role of the stub API - it allows you develop the majority of the front end without the need for an actual backend.

It seem you posponed some aspects of the front end until you have a real backend. That's actually fine as long as your assignment 2 addresses my concerns above. It just means you will have some extra front-end development as part of assignment 2. The mark for assignment 1 will be reevaluated at the demo for assignment .

[This thread is now closed. Feel free to continue the discussion in the lab classes.]worked your way through the Hacker News