search

ewasm / design

Ewasm Design Overview and Specification
Apache License 2.0
1.02k stars 125 forks source link

Support codespell #142

Closed bakaoh closed 6 years ago

bakaoh commented 6 years ago

and correct typos

Fix #141

bakaoh commented 6 years ago

@axic -- i updated as your request, although i still prefer run-list to multi-line command

vs77bb commented 6 years ago

@axic I think this one might be with you for review, still? 🙂

axic commented 6 years ago

I wonder why this hasn't caught the typos from #139. Though mostly only large vs.lage could have been caught.

bakaoh commented 6 years ago

I wonder why this hasn't caught the typos from #139. Though mostly only large vs.lage could have been caught.

It is because lage is not in codespell dictionary file https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary.txt. I can add a custom dictionary for this word but it's solve nothing. It's better to improve codespell itself to contain more common misspellings. Also because the way they do it (by using a dictionary file), i don't think we should expect that will catch all typos