search

ewasm / go-ethereum

Official Go implementation of the Ethereum protocol
https://geth.ethereum.org
GNU Lesser General Public License v3.0
27 stars 4 forks source link

increase max http message size by factor of 10 #16

Closed jwasinger closed 5 years ago

jwasinger commented 5 years ago

Otherwise we can't deploy bigger WRC20 contracts over RPC.

axic commented 5 years ago

How big are these contracts btw? Does chisel repack help?

jwasinger commented 5 years ago

Yeah actually... I need to figure out what's bloating these contracts because they shouldn't be as large as they are.

I got @hugo-dc 's down to about 50kb. Using #[no_mangle] increases the size to 150k. Seems bloated..

What is chisel repack?

axic commented 5 years ago

What is chisel repack?

Removes unneeded sections: https://github.com/wasmx/wasm-chisel/pull/88

axic commented 5 years ago

Oh never mind I've missed the fact this changes the RPC limit!

Yes, the RPC should be aligned to the codeSizeLimit.

@gballet perhaps this is an upstream thing which could be improved?

axic commented 5 years ago

on the contrary, this is exactly the kind of stuff that will never be upstreamed: it's a DoS vector.

I didn't mean the PR, but the actual concept, that the RPC size should depend on the code size limit.

axic commented 5 years ago

@jwasinger @gballet as part of EIP-2028 a relevant change is proposed for geth: https://github.com/ethereum/go-ethereum/pull/19618