ewasm / hera

Hera: Ewasm virtual machine conforming to the EVMC API
Apache License 2.0
179 stars 50 forks source link

Run codecov on all engines #546

Closed axic closed 5 years ago

axic commented 5 years ago

@chfast can you have a look why codecov is failing?

To be clear, why compilation fails:

FAILED: CMakeFiles/wabt.dir/src/string-view.cc.o 
/usr/bin/g++  -D__STDC_FORMAT_MACROS=1 -D__STDC_LIMIT_MACROS=1 -I/home/builder/build/deps/src/wabt -I. -fvisibility=hidden -std=c++11 -Wold-style-cast -O3 -DNDEBUG -fPIC   -Wall -Wextra -Wno-unused-parameter -Wpointer-arith -g -Wuninitialized -Wno-clobbered -MD -MT CMakeFiles/wabt.dir/src/string-view.cc.o -MF CMakeFiles/wabt.dir/src/string-view.cc.o.d -o CMakeFiles/wabt.dir/src/string-view.cc.o -c /home/builder/build/deps/src/wabt/src/string-view.cc
/tmp/ccwaAQst.s: Assembler messages:
/tmp/ccwaAQst.s: Error: can't read from /tmp/ccwaAQst.s: Cannot allocate memory
chfast commented 5 years ago

The compiler went OOM.

codecov-io commented 5 years ago

Codecov Report

Merging #546 into master will increase coverage by 20.68%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #546       +/-   ##
===========================================
+ Coverage   50.73%   71.41%   +20.68%     
===========================================
  Files           8        9        +1     
  Lines        1354     1536      +182     
  Branches      130      136        +6     
===========================================
+ Hits          687     1097      +410     
+ Misses        640      411      -229     
- Partials       27       28        +1
axic commented 5 years ago

@chfast would it be a lot of work splitting up coverage into:

chfast commented 5 years ago

@chfast would it be a lot of work splitting up coverage into:

* running all engines (this will not allow us to see if the eei is covered properly)

* running only wabt to see if it covers the entire eei properly

A bit. On codecov you can tag different data uploads, but codecov is not able to filter these in web UI. Maybe coveralls can do it.

axic commented 5 years ago

@chfast thanks for fixing this!