search

ewasm / testnet

Testnet planning & documentation
64 stars 19 forks source link

Some misc README cleanup #102

Open lrettig opened 5 years ago

lrettig commented 5 years ago

Saving work in progress. Going to try to merge some in flight PRs and rebase against those.

axic commented 5 years ago

96 was merged, please rebase.

lrettig commented 5 years ago

This is ready to go but will likely conflict with #115

axic commented 5 years ago

Rebased - because it was hard to follow what is going on with merge commits.

lrettig commented 5 years ago

From my perspective this is ready to merge, @axic ?

lrettig commented 5 years ago

Is this ready to go? Ping

axic commented 5 years ago

I'm not sure why wagon was moved out of the main doc.

lrettig commented 5 years ago

I'm not sure why wagon was moved out of the main doc.

I moved it into a side doc because it's not ready for production yet. I did the same thing for aleth. Would prefer to keep the master doc as focused and simple as possible. @axic is there a reason you want it in the main doc?

axic commented 5 years ago

I've pulled out two major changes from here and merged them separately.

is there a reason you want it in the main doc?

Wagon is ready and passing the tests (as of yesterday). It is planned to be the main client for 2nd milestone. Don't wanna move it back and forth.

lrettig commented 5 years ago

Then can we remove the part that says "this spec may be wrong and will change"?

On Mon, 26 Nov 2018 at 14:47, Alex Beregszaszi notifications@github.com wrote:

I've pulled out two major changes from here and merged them separately.

is there a reason you want it in the main doc?

Wagon is ready and passing the tests (as of yesterday). It is planned to be the main client for 2nd milestone. Don't wanna move it back and forth.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ewasm/testnet/pull/102#issuecomment-441663616, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKbNHe942084yOFpXRkHMAigiMozdPGks5uy_7ogaJpZM4YcD7o .

axic commented 5 years ago

@gballet is wagon working now properly? Can we remove the warning?

axic commented 5 years ago

@gballet ping https://github.com/ewasm/testnet/pull/102#issuecomment-441668640

gballet commented 5 years ago

@axic wagon is working with some issue that I found, need to create the PR for the fix and have them integrate them.

lrettig commented 5 years ago

Did you remove the assemblyscript docs via force push? 😑

axic commented 5 years ago

Did you remove the assemblyscript docs via force push? 😑

Didn't remove any assemblyscript docs.

lrettig commented 5 years ago

Can we just merge this, then update the wagon stuff later as necessary?

axic commented 5 years ago

Can we just merge this, then update the wagon stuff later as necessary?

There is little point applying all these wagon changes from this PR if we need to roll it back 100%. Wagon just works.

lrettig commented 5 years ago

It would be great to get this merged, and iterate. There's a bunch of confusing/misleading stuff in the master doc right now that this fixes.

axic commented 5 years ago

There's a bunch of confusing/misleading stuff in the master doc right now that this fixes.

Can you please list what is this fixing? The C++/Rust swap is not relevant anymore, Wagon is not experimental anymore.

lrettig commented 5 years ago

This PR is not about C++/Rust or Wagon. It's about misc doc cleanup. The bulk of these changes are still relevant. Is there some specific concern here? If not, can we merge and iterate?