search

ewasm / testnet

Testnet planning & documentation
64 stars 19 forks source link

Implement codeFromFile in genesis in geth #70

Closed axic closed 5 years ago

axic commented 6 years ago

Currently the genesis.json support a field code which takes a hex string as value.

Goal is to implement codeFromFile which takes a file path (relative to the path of the genesis.json) and loads the code form there, still considering it as a hex string.

This feature is implemented in aleth already.

jwasinger commented 6 years ago

I'm opting to write a script to generate the genesis file programmatically. I think this would be an easier route than adding this feature to geth.

jwasinger commented 6 years ago

Implementing this in Geth should be as simple as changing this line: https://github.com/ethereum/go-ethereum/blob/7beccb29becf439df7bf4c033a94c019ad25bead/core/genesis.go#L228

axic commented 6 years ago

So it seems the geth team is against this and would like to see a genesis modifying tool instead.