eweitz / ideogram

Chromosome visualization for the web
https://eweitz.github.io/ideogram
Other
294 stars 71 forks source link

legend name misplaced with row name #283

Closed rdcwuyy closed 2 years ago

rdcwuyy commented 3 years ago

Dear Eric,

Thanks for this great tool ideogram.js again.

Could you please take a look at a small issue regarding the legend labels? The legend name seems to be misplaced as the label for the first row, and therefore the last row is missing its icon.

Here is a picture of a legend:

Screenshot 2021-09-11 at 22 02 03

And here is the source for that legend:

var legend = [{
  name: 'Clinical significance (simulated)',
  rows: [
    {name: 'Pathogenic', color: '#F00', shape: shape},
    {name: 'Uncertain significance', color: '#CCC', shape: shape},
    {name: 'Benign', color: '#8D4', shape: shape}
  ]
}];

Thanks and best regards, Yanying

eweitz commented 3 years ago

Greetings! This is fixed via #287.

I aim to release an update including this fix in a week or so. If you need it beforehand, you can build from source.

eweitz commented 2 years ago

This fix has been released with Ideogram 1.32.0. Thanks again for reporting the issue!

rdcwuyy commented 2 years ago

Great! Thank you so much!

Best wishes, Yanying

在 2021年12月1日,13:55,Eric Weitz @.***> 写道:

This fix has been released with Ideogram 1.32.0. Thanks again for reporting the issue! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.