search

eweitz / ideogram

Chromosome visualization for the web
https://eweitz.github.io/ideogram
Other
294 stars 71 forks source link

Fix rotate-on-click for chromosomes fetched from NCBI #331

Closed eweitz closed 1 year ago

eweitz commented 1 year ago

This fixes rotation-on-click for chromosomes that lack native cytogenetic banding data.

Previously, if a genome were fetched from NCBI, clicking a chromosome would rotate it, then the chromosome would disappear. This was due to a slightly misconfigured length property for such chromosomes.

Now, length is properly set, and such chromosomes rotate as expected upon click. A new automated test protects against regression.

Here's how the fix looks in grape (Vitis vinifera); compare to bug visuals in #330.

https://user-images.githubusercontent.com/1334561/207322611-aa323d24-6d56-4741-88e3-1f1452e6f8d4.mov

coveralls commented 1 year ago

Coverage Status

Coverage increased (+2.4%) to 86.584% when pulling d4181d8a5de3560cdb741a6d8574015eaf79a496 on rotate-non-native into 331e338d6b5824e850e4d464c7c4b831dd5e83c0 on master.