search

ewels / CPT-Bootstrap-Carousel

WordPress plugin which generates a custom post type for choosing images and content. Outputs Bootstrap Image Carousel (slider) HTML from a shortcode.
http://wordpress.org/plugins/cpt-bootstrap-carousel/
GNU General Public License v2.0
51 stars 36 forks source link

Include relevant bootstrap CSS and JS #68

Open ewels opened 9 years ago

ewels commented 9 years ago

Ok, so including the entire bootstrap CSS will break people's websites, but I could make a stripped down version which targets the carousels specifically. Then give the option of including these files.

This would have the added benefit that the carousel could be used on non-bootstrap sites.

RKS213 commented 8 years ago

Not much but to make this easier you can load a page with just the carousel and nothing else HTML wise and use the Chrome extension "CSS Remove and Combine" and it will pull all CSS used on that page into it's own file for you. Just make sure the carousel is the only thing on the doc and that you're loading all the relevant Bootstrap files and it'll take you five seconds to get the exact styles you need.

Also, it would be wise to make it an option since many users will already be loading Bootstrap.

ewels commented 8 years ago

Awesome - thanks for the tip @RKS213! I'll definitely use that when I get to this issue.

Yes, this would definitely be an opt-in feature, and a pretty low priority one at that as I expect most users to be using bootstrap already. I just thought that it could open up the plugin to more sites.

For my own reference, I assume that this is the tool you're referring to..

RKS213 commented 8 years ago

That is the correct addon I was talking about.

As for myself, I do not need this feature, I was just looking around and somehow managed to come in here. I like using the CDN for bootstrap and would personally want to disable any overriding CSS that might come from a plugin. Just my 2 cents I think you're correct to just require people to use Bootstrap already.

ewels commented 8 years ago

Yup - would definitely make it turned off by default.