search

ewels / CPT-Bootstrap-Carousel

WordPress plugin which generates a custom post type for choosing images and content. Outputs Bootstrap Image Carousel (slider) HTML from a shortcode.
http://wordpress.org/plugins/cpt-bootstrap-carousel/
GNU General Public License v2.0
51 stars 36 forks source link

Error in a11y #84

Open ricardomoro opened 8 years ago

ricardomoro commented 8 years ago

This error appears in the accessibility audit tool a11y:

✖ The purpose of each link should be clear from the link text

#cptbc_973 > .left.carousel-control
#cptbc_973 > .right.carousel-control

I'm using Twitter Bootstrap Version 3 output.

ewels commented 8 years ago

Thanks for the report - what would fix it? I notice that the bootstrap docs now have role="button" which isn't in the markup produced by the plugin.. (also screen reader only text)

ricardomoro commented 8 years ago

I think that besides the role="button", the links need a text content. As you said, a screen reader only text should be sufficient. Furthermore, aria-hidden="true" must be placed in the glyphicon span, such as the Bootstrap docs shows.

ewels commented 8 years ago

Thanks @ricardomoro - I will add these when I next do some work on the plugin (could be while, I haven't actually used it myself for years now). Feel free to open a PR if you'd like to see it added sooner.

Phil

ricardomoro commented 8 years ago

Ok @ewels, thank you! I'll do that, as soon as I use the plugin again.