search

ewels / CPT-Bootstrap-Carousel

WordPress plugin which generates a custom post type for choosing images and content. Outputs Bootstrap Image Carousel (slider) HTML from a shortcode.
http://wordpress.org/plugins/cpt-bootstrap-carousel/
GNU General Public License v2.0
51 stars 36 forks source link

Less shortcode options, more admin UI #9

Closed ewels closed 10 years ago

ewels commented 11 years ago

Look into migrating some (all?) of the shortcode options into the administration user interface for easier use.

Potentially look to Contact Form 7 as an example of how to do this. Might be able to move some of the carousel options into the category pages? Don't want to force people to use categories though (shortcode options could override these).

ewels commented 11 years ago

There are quite a lot of shortcode options now. Also, using a HTML user interface would mean restricting input for certain shortcode attributes (eg.orderby) to supported values. Could be helpful for people.

ewels commented 11 years ago

Could have a settings page with defaults? Then shortcode atts to override these?

ewels commented 10 years ago

Implemented in commit 235f985250

theodorocaliari commented 10 years ago

Hi Tall Phil, I agree with this... I make some little modifications to, show caption box or hidden caption box... how I can send to you to see it? I make a pull request only to show you right? thanks again to make and share this plugin!

ewels commented 10 years ago

Hi @theodorocaliari,

I've already implemented the settings page, but yes - if you submit a pull request then I can see any modifications that you've made to the code yourself.. I'm not entirely sure what you mean about the caption box ;)

Cheers,

Phil

theodorocaliari commented 10 years ago

Well, sorry if I confuse somthing...

The idea is, when I don't have image with caption text, only image with link, or images with text in image... well I make the changes in this link, I not much familiar with github... haha

My modifications in this link: https://github.com/theodorocaliari/cpt-bootstrap-carousel/commit/d0be8719b6f3f952dbeedfa727cb88c0d4921ecd how I can pull request you?

Cheers

ewels commented 10 years ago

Ok, thanks - normally I just leave the text area blank if I don't want a caption.. Does this not work for you or is there a specific reason to use a category to remove the caption text?

theodorocaliari commented 10 years ago

When I leave blank, the box keeps showing up, but empty... for this reason I make the query and conditional class in your plugin to hidden this empty box from slider or hide it when I want... Maybe a metabox Is better than especific taxonomy term to make this "on/off" in caption box... :)

theodorocaliari commented 10 years ago

A print of backend and front-end example with and without caption text... http://snag.gy/VpiHd.jpg

ewels commented 10 years ago

Ah ok, how about I just put in an extra test to make sure that there is at least a title or caption, and if there isn't then the <div class="carousel-caption"> div isn't printed out at all (then you would have no empty red square).

To me this seems a little simpler and more intuitive to use than having to set up categories (it's something that I should have thought to include in the original release really), though your workaround is very elegant!

Is this ok? I can push the change out in the next release..

Phil

theodorocaliari commented 10 years ago

Perfect! I basically hookie in wordpress and my solutions sometimes is very hard to take effects... thanks for kind words... :)

Ok for me, but you're the boss...

see ya!