search

ewels / CPT-Bootstrap-Carousel

WordPress plugin which generates a custom post type for choosing images and content. Outputs Bootstrap Image Carousel (slider) HTML from a shortcode.
http://wordpress.org/plugins/cpt-bootstrap-carousel/
GNU General Public License v2.0
51 stars 36 forks source link

Enhancement for Bootstrap 4.x #92

Closed ewels closed 6 years ago

ewels commented 6 years ago

PR opened by Phil based on issue #91

ewels commented 6 years ago

Hi @danielnielsen,

I need to run now but will look at this later. In the mean time, the first thing I notice is that there are lots of whitespace changes in the diff. If you could clear these up then it makes reviewing the code changes a lot easier..

Thanks!

Phil

danielnielsen commented 6 years ago

Hi @ewels

I've done some whitespacing on the if-chunck in cptbc-frontend.php :)

ewels commented 6 years ago

Cool, thanks! Sorry - I wasn't very clear though. I more meant this kind of whitespace: image

https://github.com/ewels/CPT-Bootstrap-Carousel/pull/92/files#diff-9f120320a3587269828c209e436e4b4aL105

danielnielsen commented 6 years ago

Are we good on this one? :)

ewels commented 6 years ago

Sorry, I was waiting for you to clear up the whitespace stuff that I mentioned in my last comment. Being pedantic I know, but it accounts for over half of the changes in the PR so would be nice to clean it up if possible..

ewels commented 6 years ago

meh, I should stop worrying. Looks good, thank you :)