PHP Split Function

[darogan]

As of PHP version 7.0.0 the split function has been removed (see http://php.net/manual/en/function.split.php)

Ubuntu 16.04 ships with 7.0.8 so reports.php is failing on lines 127 & 130

Suggested change:

foreach(split(" ",$dataset['accession_geo']) as $geo)

to

foreach(preg_split(" ",$dataset['accession_geo']) as $geo)

[ewels]

Thanks @darogan! I'm on honeymoon and only on my phone until mid February so can't do much before then. If you submit a PR with the change I should be able to merge though.

Phil

[ewels]

ps. A regular expression doesn't seem to be necessary here, so explode is probably better. I imagine I used split mostly because that's what other languages call the function.. :)

[darogan]

Stop checking your emails if you are on your honeymoon!

I'm just getting back into using Labrador to serve out NGS data. I have loads of new "features", but will wait until you are back before submitting any PRs. I seems to be working well, but I'll get a chance to iron out any bugs in the next few weeks.

[darogan]

My updates are here https://github.com/darogan/labrador, but no PRs until you are back.

[ewels]

Haha, ok - sounds good! 😂

[ewels]

Closed in #14