ewels / Labrador

A web based tool to manage and automate the processing of publicly available datasets.
https://www.bioinformatics.babraham.ac.uk/projects/labrador/
GNU General Public License v3.0
37 stars 9 forks source link

Email verification #13

Open jcgrenier opened 7 years ago

jcgrenier commented 7 years ago

Hi @ewels,

I've been struggling a bit with Labrador installation on a Docker. I'm still trying to figure it out. I'm almost there, but there's still two things for which I have troubles. I've installed ssmtp for the php mail() function. It seems to work, since when I'm doing tests by command line, it's sending well. It doesn't seems to be the case with the interface thought. So, I'm not able to proceed to email verification.

The other problem I have, maybe you can answer to this question easily. I'm putting my email address as administrator, but the system doesn't recognize it and still wants to process with the email verification step. Do you know how I can bypass this?

Thanks a lot for your help!

Ah, btw, I took @darogan version since it was compatible with PHP7 : https://github.com/darogan/labrador

JC

ewels commented 7 years ago

Hi @jcgrenier,

Thanks for the report. I'd like to wait for @darogan to submit a PR with his changes before I do any work or testing on this if possible. Also to get set up with docker myself. I haven't actually run Labrador myself in over three years now so I can't remember exactly how the administrator stuff works off the top of my head sorry.

Phil

darogan commented 7 years ago

Hi @ewels @jcgrenier,

I found a couple more PHP7 changes and I still need to push them to the repo. I'll add them this morning and then submit a PR.

I looked at my docker images, and they are a bit of a mess as I was trying lots of different things. Starting from scratch is probably a better idea.

Russell

jcgrenier commented 7 years ago

Hi @ewels and @darogan,

Thanks for your reply. I'll wait a bit then and see what you came up with. My docker is almost up for running. The only questions I still have concerning this is how to add up the database to make sure I'm not erasing it in any case my container is closing up. I'll do some tests on that once Labrador is up and running well on it.

Thanks! JC

darogan commented 7 years ago

@ewels @jcgrenier I added some minor tweaks to my repo for more PHP7 compatibility I also submitted a PR with all the updated to Phil

jcgrenier commented 7 years ago

Hi @darogan,

Super! Do you have more details about the email verification issue that I'm having concerning the administrator(s)? Is it possible to go in the code directly (in a mysql database I suppose) to manually accept a user?

Thanks a lot for your help! It's really appreciated! JC

darogan commented 7 years ago

@jcgrenier The user table in the database gets a verification code when a user registers. I was then extracting this and manually emailing it to the user. However, I think it might be possible to just delete the code from the users entry in the table, thus fooling Labrador into thinking the user had verified via email.

Scripting this should be easy enough

jcgrenier commented 7 years ago

@darogan Cool I was able to get throught. But why does it's still asking me even if I'm an admin?

Thanks!

ewels commented 7 years ago

@jcgrenier - the short answer is that it's probably quite stupid :) I'm not sure how many people run Labrador, but it can't be many sites. This is an issue that is only encountered once when first installed, so it's never been a priority to write special-case handling for this.