ewels / clusterflow

A pipelining tool to automate and standardise bioinformatics analyses on cluster environments.
https://ewels.github.io/clusterflow/
GNU General Public License v3.0
97 stars 27 forks source link

Error with Bismark methylation extractor gwcov option #24

Closed FelixKrueger closed 9 years ago

FelixKrueger commented 9 years ago

The gwcov option (#bismark_methXtract gwcov) tries to find scripts in your home directory and thus fails. Cheers, Felix

ewels commented 9 years ago

Yup, this is actually the desired behaviour. Unless I bundle these scripts with cluster flow (which I don't want to do) or assume that they are in the PATH (which seems unlikely), users will have to edit this module to include the location of their scripts.

The right way to do this would be to read the paths from the config file of course, but I'm hoping that this chunk of module will soon be replaced if and when they are incorporated into bismark ;)

Also, they should only throw a warning and not fail. Let me know if this isn't the case, and cluster flow is actually falling over because of it.

ewels commented 9 years ago

TODO: Remove the word 'error' from the warning so that it isn't flagged in the e-mail report.

ewels commented 9 years ago

Fixed in https://github.com/ewels/clusterflow/commit/73fcb659e15fd85be66a9c2560c0555c9c9515bf