Closed orzechoj closed 9 years ago
Thanks again for this work - much appreciated. Apologies for all of the comments - many are duplicates of each other, so hopefully doesn't actually add up to many changes.
Let me know if you have any questions or I can help.
Great, thanks again @orzechoj! The only thing I can see remaining is the unused copy module import, which is really not very important. Are you planning to do any more changes, or are you happy for me to merge this?
Phil
Yes it's that and rounding the results in the module that computer nrf. None of these things are very important so you you can go ahead and merge.
I just tested it again after all changes and it ran fine. The only strange thing was that when did qs while it was running, some jobs were missing (even though they eventually ran ok).
I'm on my way to lunch now, but can send more details later if you want.
Jakub
Yup - the weird output from qs
is because I broke it with a recent update - see #64. I'll fix that soon hopefully.
Cool - I'll merge and do the two minor updates myself as it's a very quick change.
Great!
On Thu, Jun 25, 2015 at 2:21 PM, Phil Ewels notifications@github.com wrote:
Yup - the weird output from qs is because I broke it with a recent update
- see #64 https://github.com/ewels/clusterflow/issues/64. I'll fix that soon hopefully.
Cool - I'll merge and do the two minor updates myself as it's a very quick change.
— Reply to this email directly or view it on GitHub https://github.com/ewels/clusterflow/pull/66#issuecomment-115231930.
Ok - changes done and pushed. If you wouldn't mind testing it just one last time, that would be great! I changed one or two other minor things as well (eg. using $ENV{'PATH'}
instead of importing the Env
module).
…es, 1 new pipeline6 new modules, 1 new pipeline6 new modules, 1 new pipeline6 new modules, 1 new pipeline