search

ewels / rich-click

Format click help output nicely with rich.
https://ewels.github.io/rich-click/
MIT License
630 stars 36 forks source link

Deprecate click 7.x support #117

Closed dwreeves closed 1 year ago

dwreeves commented 1 year ago

Resolves #116

Mostly self-explanatory PR.

I did not add TODO comments because all the parts of the code that need to be changed are easy enough to find in the code (basically, anywhere that CLICK_IS_BEFORE_VERSION_8X is referenced).

Lastly, on the topic of deprecation warnings, I removed distutiils.version.LooseVersion and swapped with packaging.version.parse since distutiils is deprecated and is slated to be removed in Python 3.12, via PEP-632 https://peps.python.org/pep-0632/ And I don't see any good reason for the next version release to not work with Python 3.12, even if only temporarily.

ewels commented 1 year ago

Probably should have added a changelog entry for this.. 🤔