ewerybody / a2

Autohotkey module managing and developing framework.

GNU General Public License v3.0

63 stars 10 forks source link

Hotkey dialog: show conflicts #150

Open ewerybody opened 6 years ago

ewerybody commented 6 years ago

Expected Behavior

A Hotkey dialog needs to show conflicts before anything can be messed up.

Current Behavior

There is nothing. The dialog allows anything :/

Possible Solution

[x] Have a list of standard Windows-Shortcuts that can be overridden.
[x] Check against the internal list of already setup hotkeys.

this is a #15 follow up

further things to finish this:

[x] add scoped conflict check
[ ] add confirmation line to dialog
[x] add "I know what I'm doing"-checkbox for Global Hotkeys without Modifier
[ ] replace standard Tooltip thing with custom popup
[ ] show Windows icon or module icon in tooltip

ewerybody commented 6 years ago

118 is done! The hotkey collector will produce a nicely searchable dictionary now.

We'd need another list of standard hotkeys. Like commonlt known ones (F5: reload, Ctrl+S: save ...) or default windows (Win+D: show desktop, Ctrl+w: close tab, Alt+F4: close window)

lipkau commented 6 years ago

I would recommend having this in a json file - preferably in a git repository of its own - so that it can be extended (and PRed) without interfering (creating diffs) with the rest of the code.

I propose a a2script/commonKeyBindings repository which is in a2's .gitmodules

ewerybody commented 6 years ago

Yea for sure I would make it a json file but I wasn't thinking of a separate repo so far 🤔 but yea we can do that!

lipkau commented 6 years ago

We don't need to do that from the get-go. We can extract it later on.

ewerybody commented 5 years ago

Update! :) click for video:

ewerybody commented 4 years ago

Ok. There is now this:

So for instance to make this Capslock override work. This is necessary.