ewerybody / a2

Autohotkey module managing and developing framework.
GNU General Public License v3.0
63 stars 10 forks source link

fix ui recompile check to use Qt wrapper ++ #219

Closed ewerybody closed 3 years ago

ewerybody commented 3 years ago

Currently the ui recompile check uses the PySide version currently imported in the ui code and ignores our wrapper that works with whatever version right away.

While we're at it we could fix some more annoyances in there.

ewerybody commented 3 years ago

whow! This shaved off over 30 lines from a2design_ui.py for example! 👍 I think the broad import removal and the brunette post process are too much for this task now. This is already MUCH better :)

ewerybody commented 3 years ago

https://github.com/ewerybody/a2/commit/9d6bebf1c4f72375c0842b7696fe4809639e139e just fixed "get rid of broad * imports"

I doubt we're gonna go "brunette compliant" because that'd mean unfolded imports or comments to keep them in one line or make all Qt imports prefix with their submodule ... like we code actually ... :| still possible ... but little benefit.

ewerybody commented 3 years ago

after all we should look into improving this by fixing the actual uic++