Un/Installer move ops are not error proof!

ewerybody / a2

Autohotkey module managing and developing framework.

GNU General Public License v3.0

63 stars 10 forks source link

Un/Installer move ops are not error proof! #273

Closed ewerybody closed 1 year ago

ewerybody commented 1 year ago

Currently when the un/installers move files and folders and they might fail (for instance: Have the ui dir open in a cmd window.) we're not getting any feedback! The thing continues like nothing happened.

[x] have move function that collects each file that was moved already
[x] whenever a file fails to get moved the whole thing fails and rolls back all already moved files

ewerybody commented 1 year ago

There is now move_catched https://github.com/ewerybody/a2/blob/240aaa35b4955cf6e5ca7a7db125f1947ff4f39b/lib/Autohotkey/lib/move.ahk#L28 and the installer is patched accordingly https://github.com/ewerybody/a2/blob/240aaa35b4955cf6e5ca7a7db125f1947ff4f39b/lib/_source/a2_installer.ahk#L135