search

ewestern / geos

This is a Haskell binding to Geos, the open-source geometry library
MIT License
13 stars 9 forks source link

tidy up tests #8

Closed jamiecook closed 7 years ago

jamiecook commented 7 years ago

This PR

  1. tidies up the tests suite and starts to break it into separate modules.
  2. addresses the glaring error I left in my previous test (compare line with polygon what the?)
  3. Adds a sum type to wrap up the typeId integer
  4. Starts adding tests for basic geo operations (which is currently causing memory failures for multiPolygons)
ewestern commented 7 years ago

Thanks for the work on the tests. I pushed another commit to peter/pr-3, which, when run against your test suite, seems to have cleared up all demonstrated memory issues so far. We should probably rebase this branch off that commit.

Further, it strikes me that there are likely memory leaks that need to be found as well. I should create some benchmark tests and profile the heap to track those down.

jamiecook commented 7 years ago

Rebase is done and all tests are passing!!