ewewukek / mc-musketmod

Mod that adds craftable flintlock weapons
MIT License
13 stars 22 forks source link

A couple of fixes & a Korean translation! #1

Closed lilypuree closed 4 years ago

ewewukek commented 4 years ago

thanks for contribution! I think storing loading stage in nbt can theoretically cause sound lags in multiplayer scenario but didn't notice any while testing, so I'll leave it this way. CrossbowItem uses client-side vars to track it, that's why I did the same.

lilypuree commented 4 years ago

I fear it's causing lag. I have spawned in a bunch of wandering trappers and it's lagging badly... 2020-08-29_02 30 45

ewewukek commented 4 years ago

that's bit strange. musket's nbt is several bytes long it should not cause noticeable lag. I mentioned possible lag because ping may cause sound play in bad time, not a fps drop. try running a profiler, like VisualVM.