ewewukek / mc-musketmod

Mod that adds craftable flintlock weapons
MIT License
13 stars 22 forks source link

Unloaded musket arm position #42

Closed MinecraftGuy926 closed 1 month ago

MinecraftGuy926 commented 2 months ago

Minecraft Version

1.20.1

ModLoader

Fabric

Request information

In 1.5.2 the unloaded musket is held the same way as the loaded musket image

while the unloaded musket in the offhand is at ease image

I'm trying to update the 3D models resource pack. But with this new position change, I can no longer have the unloaded gun in this position which I'm very fond of image

Perhaps you could revert this change and let the unloaded musket be held like it used to be? Thanks

Other information

No response

ewewukek commented 2 months ago

it really looks nice) I'll add a predicate for relaxed state that will trigger couple seconds after firing

MinecraftGuy926 commented 2 months ago

In version 1.4.9 the unloaded musket is held like so:

2024-09-03_18 09 56 minecraft [1.20.1]

here is the same model of an unloaded musket in 1.5.2

image

Instead of a delayed change of the loaded/unloaded state, would it be possible to make it static? If not, the model will look very goofy after each shot until the arms drop back down

MinecraftGuy926 commented 2 months ago

demo of the difference between 1.4.9 and 1.5.2

https://github.com/user-attachments/assets/2ff80a6e-e9d2-48f4-a3be-ba82d8ef60d4

ewewukek commented 2 months ago

I'll make the delay configurable. instantly dropping arms felt wrong with Real Camera mod so I made it always aim so it looks like in first person view

ewewukek commented 1 month ago

made aiming optional. and added new model predicates to allow positioning guns during animations. so now there are 6 model variants for each gun:

example: musket.json

MinecraftGuy926 commented 1 month ago

Incredible! You went above and beyond. Thank you