search

ewfian / faiss-node

Node.js bindings for faiss
https://www.npmjs.com/package/faiss-node
MIT License
107 stars 10 forks source link

Feat: Add mergeFrom #32

Closed neebdev closed 1 year ago

neebdev commented 1 year ago

https://github.com/hwchase17/langchainjs/issues/2136 asked for merge_from feature like in the python version.

neebdev commented 1 year ago

There are some issues. Testing.

neebdev commented 1 year ago

Added test. @ewfian Please review and let me know. Thanks

ewfian commented 1 year ago

@neebdev Thank you so much, I will review it carefully later

neebdev commented 1 year ago

@ewfian I added the tests for exceptions, an explicit check for dimensions and also added the type definition for it.

ewfian commented 1 year ago

LGTM, Thank you. will merge in v0.3.0 after v0.2.3 released.