ewingjm / development-hub

A continuous integration solution for Power Apps.

MIT License

35 stars 8 forks source link

allow approver to complete manual merge activities #82

Closed tdashworth closed 3 years ago

tdashworth commented 3 years ago

Purpose

On our project, the user approving the Solution Merge will often also carry out the manual steps (documented in a Note). The problem is that only the creator of the Solution Merge Request can confirm these have been done via an Approval.

81

Approach

Allows both creator and approver to complete the manual merge activities.

TODOs

[x] Automated test coverage for new code
[x] Documentation updated (if required)
[x] Build and tests successful

tdashworth commented 3 years ago

Closes #81.

tdashworth commented 3 years ago

@ewingjm Thanks for reviewing. I think you need to manually trigger the checks?

ewingjm commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago

Azure Pipelines successfully started running 1 pipeline(s).

ewingjm commented 3 years ago

@tdashworth would you mind adding this into the power-apps-bindings.yml?

browserOptions:
  driversPath: ChromeWebDriver

Should fix the error you're getting on the pipeline. I was going to just bypass the policy and merge this as I know it doesn't impact the few tests that are there but I realised we'll just get the same error on the CI run and we won't get a release published.

ewingjm commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago

Azure Pipelines successfully started running 1 pipeline(s).