Strict pyright - Githubissues

ewjoachim / poetry-to-pre-commit

A pre-commit hook for syncing version numbers between poetry.lock and .pre-commit-config.yaml

MIT License

0 stars 1 forks source link

Strict pyright #17

Closed ewjoachim closed 4 months ago

ewjoachim commented 4 months ago

Closes #

Successful PR Checklist:

[ ] Tests
- [x] (not applicable?)
[ ] Documentation
- [x] (not applicable?)

PR label(s):

[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/breaking
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/feature
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/bugfix
[x] https://github.com/ewjoachim/poetry-to-pre-commit/labels/miscellaneous
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/dependencies
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/documentation

github-actions[bot] commented 4 months ago

Coverage report

This PR does not seem to contain any modification to coverable code.

souliane commented 4 months ago

CI failed because I used the "new" notation to type with builtin dict instead of from typing import Dict. Sorry, I forgot to check that beforehand :-/

PS: using dict for type hints works from python 3.9

ewjoachim commented 4 months ago

Yeah I find it more readable to use quotes when we need (plus from __future__ import annotations)