search

ewlsh / dynamic-panel-transparency

Adds Transparency To The Gnome Shell Panel
GNU General Public License v2.0
230 stars 30 forks source link

Fixed hide-corners bug #140

Closed ajbucci closed 2 years ago

ajbucci commented 3 years ago

Hey, this is my first pull request so apologies if I haven't done this quite right! This should fix the issue "Panel corners black after toggling overview"

Fixes #139

ajbucci commented 3 years ago

This is only a partial fix. The black corners will return if the background custom opacities are adjusted, though re-enabling the extension fixes it until the opacities are adjusted again. It may be due to how set_corner_color is working in theming.js?

@ewlsh Should be fixed with 58284e4

Arcitec commented 3 years ago

@ewlsh @ajbucci Thanks for trying to solve this issue. It looks like the solution here might be over-engineered?

I posted a comment on the issue ticket, which mentions how to solve this problem with 1 line of CSS:

https://github.com/ewlsh/dynamic-panel-transparency/issues/139#issuecomment-827136784

ewlsh commented 3 years ago

@ajbucci I reviewed this and listed the necessary changes, I'll apply them myself and commit this weekend unless you'd like to.

ajbucci commented 3 years ago

@ewlsh Thanks for taking the time to review the changes! I'm a bit shot at the moment as my wife and I just had our first child this past week and are still adjusting. Go ahead and apply your changes/suggestions this weekend. Thanks again!

ewlsh commented 2 years ago

Changes were manually applied, thank you :wave: