ewlsh / swfobject

Automatically exported from code.google.com/p/swfobject
0 stars 0 forks source link

IE9 and swfobject.createCSS #552

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. View swfobject.createCSS test suite in IE9

What is the expected output? What do you see instead?
Passes all tests.
All tests fail.

What version of the product are you using? On what operating system?
IE9 on Windows 7 with latest patches

Please provide any additional information below.
URL used:
http://www.bobbyvandersluis.com/swfobject/testsuite_2_2/test_api_createcss2.html

Original issue reported on code.google.com by jhiswin on 19 Apr 2011 at 9:32

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The source of the problem is IE9 standards mode no longer returns functions as 
object type.
typeof function(){} == "function" returns true in IE9 standards mode, instead 
of "object"

Therefore, swfobject.js on line 564 
http://code.google.com/p/swfobject/source/browse/trunk/swfobject/src/swfobject.j
s#564 needs to be changed to check that styleSheet.addRule() now returns 
"function" in standards mode.

Original comment by ini...@idiil.org on 20 Apr 2011 at 12:04

GoogleCodeExporter commented 9 years ago
I would like to submit a patch, but I am not sure of the best way to go about 
this.  I am not entirely sure of the reasons for needing to make sure typeof 
addRule == OBJECT, nor how I should style it (should use a const style variable 
for "function"?).  Or maybe just change it to !=UNDEF instead of ==OBJECT?

Also, this issue may have an effect on other parts of the code, although a 
cursory look does not seem to turn anything up.  I do see something in the 
removeObjectinIE that checks if the typeof == "function", but I don't know if 
this is a relevant issue for IE9.

Original comment by jhiswin on 20 Apr 2011 at 12:36

GoogleCodeExporter commented 9 years ago
I'll forward this to the team and they will update the issue status as 
required. 

Feel free to post your diff lines in a comment in the meantime so that others 
who may want to patch their copies locally can do so.

Original comment by aran.rhee@gmail.com on 20 Apr 2011 at 10:20

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Diff attached.  Changed from ==OBJECT to !=UNDEF.

Original comment by jhiswin on 21 Apr 2011 at 4:40

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the information. IE9 is putting everyone on their toes it seems. :)

SWFObject is now on Github if you'd like to fork it. 
https://github.com/swfobject

Original comment by platelu...@gmail.com on 14 May 2011 at 8:09

GoogleCodeExporter commented 9 years ago
Issue 555 has been merged into this issue.

Original comment by platelu...@gmail.com on 17 May 2011 at 11:20

GoogleCodeExporter commented 9 years ago

Original comment by platelu...@gmail.com on 20 May 2011 at 5:08

GoogleCodeExporter commented 9 years ago
jhiswin submitted a patch via GitHub

Original comment by platelu...@gmail.com on 20 May 2011 at 6:50

GoogleCodeExporter commented 9 years ago
Please test jhiswin's submission.

Original comment by platelu...@gmail.com on 20 May 2011 at 10:37

GoogleCodeExporter commented 9 years ago
Thanks.
Upgrading to swf object 2.2 - the new one - solved my IE9 problem (it failed to 
createCss during detection).
Gidon
www.koomkoom.com

Original comment by koomkoom...@gmail.com on 22 May 2011 at 3:20

GoogleCodeExporter commented 9 years ago
tried it with version 2.3 but without success.
the height didn't get resized in IE9

Original comment by bastian....@gmail.com on 18 Nov 2011 at 9:06

GoogleCodeExporter commented 9 years ago
Not fixed for me and other people. This bug is the cause of other bugs in 
swffit :
http://code.google.com/p/swffit/issues/detail?id=15

Original comment by delor.th...@gmail.com on 2 Mar 2012 at 12:21