github-actions[bot]
commented
9 months ago Lint Status
The following issues have been found with 30404-RISCV_Support_scheduling_for_sifive_p600_series-1 using gcc's ./contrib/check_GNU_style.py. Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch. If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.
=== ERROR type #1: blocks of 8 spaces should be replaced with tabs (11 error(s)) ===
gcc/config/riscv/sifive-p600.md:6:7:;; ialu████████ Integer Units: all arithmetic and logic.
gcc/config/riscv/sifive-p600.md:8:6:;; bru████████ Branch Resolution Unit: all branches.
gcc/config/riscv/sifive-p600.md:10:5:;; st████████ Memory Write Unit: all writes to memory.
gcc/config/riscv/sifive-p600.md:12:5:;; ld████████ Memory Read Unit: all reads from memory.
gcc/config/riscv/sifive-p600.md:14:7:;; imul████████ Integer Multiply Unit
gcc/config/riscv/sifive-p600.md:16:7:;; idiv████████ Integer Divide Unit
gcc/config/riscv/sifive-p600.md:18:9:;; system████████ System Unit: all coprocessor accesses.
gcc/config/riscv/sifive-p600.md:20:6:;; fpu████████ Floating Point Unit
gcc/config/riscv/sifive-p600.md:22:7:;; fmul████████ Floating Point Multiply Unit
gcc/config/riscv/sifive-p600.md:24:7:;; fdiv████████ Floating Point Divide Unit
gcc/config/riscv/sifive-p600.md:166:0:████████████████ sifive_p600_f2i,sifive_p600_fmove,sifive_p600_sfb_alu"
=== ERROR type #2: dot, space, space, end of comment (13 error(s)) ===
gcc/config/riscv/riscv.cc:452:51: {COSTS_N_INSNS (4), COSTS_N_INSNS (4)}, /* fp_add */
gcc/config/riscv/riscv.cc:453:51: {COSTS_N_INSNS (4), COSTS_N_INSNS (4)}, /* fp_mul */
gcc/config/riscv/riscv.cc:454:53: {COSTS_N_INSNS (20), COSTS_N_INSNS (20)}, /* fp_div */
gcc/config/riscv/riscv.cc:455:52: {COSTS_N_INSNS (4), COSTS_N_INSNS (4)}, /* int_mul */
gcc/config/riscv/riscv.cc:456:52: {COSTS_N_INSNS (6), COSTS_N_INSNS (6)}, /* int_div */
gcc/config/riscv/riscv.cc:457:23: 4, /* issue_rate */
gcc/config/riscv/riscv.cc:458:24: 4, /* branch_cost */
gcc/config/riscv/riscv.cc:459:24: 3, /* memory_cost */
gcc/config/riscv/riscv.cc:460:21: 4, /* fmv_cost */
gcc/config/riscv/riscv.cc:461:37: true, /* slow_unaligned_access */
gcc/config/riscv/riscv.cc:462:36: false, /* use_divmod_expansion */
gcc/config/riscv/riscv.cc:463:62: RISCV_FUSE_LUI_ADDI | RISCV_FUSE_AUIPC_ADDI, /* fusible_ops */
gcc/config/riscv/riscv.cc:464:27: NULL, /* vector cost */
=== ERROR type #3: lines should not exceed 80 characters (5 error(s)) ===
gcc/config/riscv/sifive-p600.md:28:80:(define_automaton "sifive_p600_iex,sifive_p600_fex,sifive_p600_mem,sifive_p600_div")
gcc/config/riscv/sifive-p600.md:117:80: (eq_attr "type" "unknown,arith,logical,shift,slt,multi,bitmanip,clz,ctz,rotate"))
gcc/config/riscv/sifive-p600.md:162:80:(define_bypass 1 "sifive_p600_load,sifive_p600_alu,sifive_p600_mul,sifive_p600_sfb_alu"
gcc/config/riscv/sifive-p600.md:170:80: "sifive_p600_fma,sifive_p600_f2i,sifive_p600_fmove,sifive_p600_fdiv_s,sifive_p600_fdiv_d")
gcc/config/riscv/riscv.cc:461:80: true, /* slow_unaligned_access */
=== ERROR type #4: there should be exactly one space between function name and parenthesis (3 error(s)) ===
gcc/config/riscv/sifive-p600.md:33:37:;; M-pipe ALU, MUL, DIV and I2F(integer to float instruction)
gcc/config/riscv/sifive-p600.md:35:29:;; F-pipe FPU, MUL, F2I(float to integer instruction)
gcc/config/riscv/riscv-cores.def:40:10:RISCV_TUNE("sifive-p600-series", sifive_p600, sifive_p600_tune_info)
Precommit CI Run information
Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/7769746097
Patch information
Applied patches: 1 -> 1 Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=30404 Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240131094033.42312-1-monk.chiang@sifive.com/ Patch id: 85072
Build Targets
multilib, please refer to the table below to see all the targets within that multilib.-marchstringrv32gc-ilp32d,rv64gc-lp64drv64gcv-lp64drv32gcv-ilp32d,rv64gcv-lp64dTarget Information
-marchstringgc_zba_zbb_zbc_zbsNotes
Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist. Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours. If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com